Split text effects into Colors and Decorations#669
Merged
Conversation
f51c89e to
af96065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses kas-gui/kas-text#132, replacing the old
Effecttoken with two new token types:Colorsspecifies foreground and background color whileDecorationspecifies underline and strikethrough effects.Decorations are drawn independently, which in theory allows multiple simultaneous decorations of different colors (in practice nothing uses this capability yet, and I think only something like generic HTML support would do so in practice).
Text selection/highlighting effects uses the new color tokens, replacing old special-purpose code. This is designed to allow highlighting which specifies background colors, though combining this with text selection will require modifying the token sequence at draw time.
Copies
trait FormattableTextand theMarkdownparser over fromkas-textsince these now usekas-corespecific effect tokens. For now, the old versions still live inkas-text.