Skip to content

Comments

Split text effects into Colors and Decorations#669

Merged
dhardy merged 14 commits intomasterfrom
push-tqvkkynnzolm
Feb 20, 2026
Merged

Split text effects into Colors and Decorations#669
dhardy merged 14 commits intomasterfrom
push-tqvkkynnzolm

Conversation

@dhardy
Copy link
Collaborator

@dhardy dhardy commented Feb 20, 2026

Uses kas-gui/kas-text#132, replacing the old Effect token with two new token types: Colors specifies foreground and background color while Decoration specifies underline and strikethrough effects.

Decorations are drawn independently, which in theory allows multiple simultaneous decorations of different colors (in practice nothing uses this capability yet, and I think only something like generic HTML support would do so in practice).

Text selection/highlighting effects uses the new color tokens, replacing old special-purpose code. This is designed to allow highlighting which specifies background colors, though combining this with text selection will require modifying the token sequence at draw time.

Copies trait FormattableText and the Markdown parser over from kas-text since these now use kas-core specific effect tokens. For now, the old versions still live in kas-text.

@dhardy dhardy merged commit c9f661c into master Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant